fix: add global or import scripts into DOM #1030
Conversation
|
Visit the preview URL for this PR (updated for commit cc73007): https://react-kitchen-sink-dev--pr1030-1027-add-global-and-mit9l9lq.web.app (expires Tue, 25 Feb 2025 18:52:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
|
| ${importedScripts || ""} | ||
| ${globalBlock || ""} |
There was a problem hiding this comment.
You need to wrap this in a function that will be unique by screen. When the script loads, it should execute this function that returns a closure object with a function to eval, with an expression and context.
It should look like this
// script tag content, rename unique by screen
const createEvalClosure = () => {
// importedScripts
// globalScripts
return (expression, context) => {
// evalCode
}
}
const evalInClosure = createEvalClosure()
// elsewhere
evalInClosure(expression, context)There was a problem hiding this comment.
You will still need to define ensemble in the window.
Describe your changes
Add global or import scripts into DOM to reduce the load on buildEvaluateFunction
Screenshots [Optional]
Issue ticket number and link
Closes #1027
Checklist before requesting a review
pnpm changeset add